Skip to content

Conversation

@tnagorra
Copy link
Contributor

@tnagorra tnagorra commented Jan 9, 2023

Address

- Using setUTCHours will use UTC as reference while setting the values
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thenav56 thenav56 changed the base branch from master to dev January 9, 2023 10:30
@danbjoseph
Copy link
Member

danbjoseph commented Jan 9, 2023

does this also fix this issue below? where the "Time Spent Contributing" shows contributions on Jan 1 (which is a Sunday) but the "by Day of Week" graph shows nothing for Sunday. link
Screen Shot 2023-01-09 at 1 57 09 PM

looks like one chart is off - Monday is Jan 2
Screen Shot 2023-01-09 at 2 05 03 PM
Screen Shot 2023-01-09 at 2 05 05 PM

@thenav56
Copy link
Member

Hi @danbjoseph
Yes, it will solve the issue.
The issue was with the time series instead "by Day of Week" graph. It will now point to the correct day in the time series.
You can check this URL to compare.
[With issue] https://community.mapswipe.org/?from=2022-11-01&to=2022-11-30
[Without issue] https://mapswipe-community-dashboard.dev.togglecorp.com/?from=2022-11-01&to=2022-11-30

Also, thanks for the typo fix.

- Change layout for area on information card
@Hagellach37 Hagellach37 merged commit 03dc36f into dev Jan 16, 2023
@Hagellach37 Hagellach37 deleted the fix/date-seconds-reset branch January 16, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants