Conversation
ecgreb
reviewed
Jan 27, 2017
| s.social_media_url = 'https://twitter.com/mapzen' | ||
| s.documentation_url = 'https://mapzen.com/documentation/ios/' | ||
| s.source = { :git => 'https://github.com/mapzen/ios.git', :branch => 'master' } | ||
| s.source = { :git => 'https://github.com/mapzen/ios.git', :tag => "v#{s.version}" } |
Collaborator
There was a problem hiding this comment.
We will need to manually push the tag v0.1.0 to this repo after this merges, correct?
Member
Author
There was a problem hiding this comment.
Yeah. I was doing some reading and it seems like if you tag on the branch and do a merge commit it is fine, but tags don't really live in branches so it's weird.
ecgreb
approved these changes
Jan 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally given how the podspec dependencies are defined we shouldn't have to alter this podspec further as we update the beta releases of the underlying frameworks.