Has .selector property been missed during jQuery 3.X compatibility changes?

[mmourao211]

Hello,

.selector property has been removed from jQuery 3

Assuming you suggest fancytree now supports jquery 3.X, is the following line a bug?

fancytree/dist/jquery.fancytree-all.js

Line 6502 in 2fb0b62

} else if (el.selector !== undefined) {

If it's not a bug, can you please explain why this is ok? From what I see, the code within the else if would never execute even if el is a jQuery element.

Thanks,
Michael

[mar10]

This line was a test if el is a jQuery object, but breaks for jQuery 3, so yes: that is a bug.
What was the symptom that you observed?

[mmourao211]

What was the symptom that you observed?

Nothing actually. We just flagged this when testing jquery dependent libraries for compatibility. But this was flagged during regex scanning of the files, could not actually see any symptoms.

Thanks for fixing.

One last question if you don't mind: When supporting jQuery 3.X in fancytree, did you remove all deprecated functionality, or just removed/breaking changes?

Yours,
Michael

[mar10]

Currently jQuery 1.9+ is listed as min. requirement, may be it's time to drop this.
But I did not even check yet which deprecated methods could be removed for the 1.9 case.