Prevent default behavior on hot key combination #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar10
reviewed
Mar 11, 2017
| $(tree.$container).on(event, null, key, function(evt) { | ||
| var node = tree.getActiveNode(); | ||
| handler(node); | ||
| evt.preventDefault(); |
There was a problem hiding this comment.
Wouldn't it be more flexible to let the handler decide whether he wants to prevent default handling, stop propagation or both?
What do you think about passing evt to the handler (which may be useful in itself), The handler can then inspect the event or call methods on it.
The main use case (stopping default handling) could be made easier to implement if we return the handler's response:
return handler(node, evt);This would allow handlers to simply return false.
If you feel that this is too much burden on the handlers, then I suggest that we make the 'prevent default' behavior configurable in the plugin options.
There was a problem hiding this comment.
Oh, you're correct. Changing handler(node) to return handler(node, evt); + handler's return false is much simpler and flexible.
One more request, a single line of comment on jquery.fancytree.hotkeys.js or on your example browser for about how to write hotkey handler function will clear this issue and much appreciated. And yes being an explicit plugin option would be good too.
Reject this change please and your answer is much better.
There was a problem hiding this comment.
Ok, if you update your PR (changing the line to return handler(node, evt); and remove evt.preventDefault()), I will merge :)
Feel free to add a comment to the example as well.
tsohr
added a commit
to tsohr/fancytree
that referenced
this pull request
Mar 20, 2017
As discussion on mar10#701, plugin to give `evt` to handlers, and handler can work with the `evt` object.
tsohr
pushed a commit
to tsohr/fancytree
that referenced
this pull request
Mar 20, 2017
Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin.
As discussion on mar10#701, plugin to give `evt` to handlers, and handler can work with the `evt` object.
|
Hi @mar10 , Done that updated for the plugin code and example. Thanks! |
|
Thanks! |
uc5288
added a commit
to uc5288/6s
that referenced
this pull request
May 17, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
lynnldvemin
added a commit
to lynnldvemin/ceabie8
that referenced
this pull request
May 26, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
lifeifeixzx
added a commit
to lifeifeixzx/agarwlq
that referenced
this pull request
May 30, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
StudioSpindler
added a commit
to StudioSpindler/anda
that referenced
this pull request
Jun 10, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
PatrickSier
added a commit
to PatrickSier/pthread
that referenced
this pull request
Jun 10, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
HeXPixCat
added a commit
to HeXPixCat/EAGLE
that referenced
this pull request
Jun 13, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
motorHillary
added a commit
to motorHillary/compact
that referenced
this pull request
Jun 13, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
yoosJacob
added a commit
to yoosJacob/kanthn
that referenced
this pull request
Jun 14, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
KeithJasons
pushed a commit
to KeithJasons/jaso
that referenced
this pull request
Jun 15, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
Gustave73
pushed a commit
to Gustave73/learn-co-studentsm
that referenced
this pull request
Jul 2, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
LionPearNews
pushed a commit
to LionPearNews/Glasklart
that referenced
this pull request
Jul 3, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
JosepehWilson
added a commit
to JosepehWilson/campbell
that referenced
this pull request
Jul 6, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
MarkeJohnson
added a commit
to MarkeJohnson/written
that referenced
this pull request
Jul 7, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
JoeFortunato
added a commit
to JoeFortunato/flathub
that referenced
this pull request
Jul 14, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
GriseldaKnight
added a commit
to GriseldaKnight/happiness
that referenced
this pull request
Jul 15, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
JudithClake
added a commit
to JudithClake/nihui
that referenced
this pull request
Jul 20, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
JoyceMoonTse
added a commit
to JoyceMoonTse/BadWolf
that referenced
this pull request
Jul 20, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
346151535
added a commit
to 346151535/negraph
that referenced
this pull request
Jul 22, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
MachinesWhisper
added a commit
to MachinesWhisper/fdress
that referenced
this pull request
Jul 29, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
892736633
added a commit
to 892736633/Solarflare
that referenced
this pull request
Aug 13, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
8937276151
added a commit
to 8937276151/FirstSpirit
that referenced
this pull request
Sep 16, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
LeoVS0
added a commit
to LeoVS0/nvim
that referenced
this pull request
Oct 7, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
jbkempfe
added a commit
to jbkempfe/ubiquitous
that referenced
this pull request
Oct 11, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
annabelledam
added a commit
to annabelledam/contaminant
that referenced
this pull request
Oct 14, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
dnfclass
added a commit
to dnfclass/rattle
that referenced
this pull request
Oct 15, 2025
* Prevent default behavior on hot key combination Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and not for else because the event was already handled by fancytree's hotkey plugin. * Hot key handler now receives event object together As discussion on mar10/fancytree#701, plugin to give `evt` to handlers, and handler can work with the `evt` object. * Add Ctrl+D hotkey example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key combination stroke (like ctrl+d, ctrl+s) will trigger browser's default behavior which is expected to be prevented and because the event was already handled by Fancytree's hotkey plugin.