Types: Add discriminated union support across language bindings#1154
Merged
Types: Add discriminated union support across language bindings#1154
Conversation
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the type system to support discriminated unions for AST node fields instead of using the generic
Nodetype as the common ancestor.The
config.ymlschema definitions have been updated to specify exact union types for fields like:HTMLElementNode.open_tag(nowHTMLOpenTagNode | HTMLConditionalOpenTagNode) (see Parser: IntroduceHTMLConditionalOpenTagNode#1153)ERBIfNode.subsequent(nowERBIfNode | ERBElseNode)HTMLAttributeValueNode.children(nowLiteralNode | ERBContentNode)HTMLCloseTagNode.children(nowWhitespaceNode)The code generation templates have been updated across all language bindings. TypeScript now generates proper union types and the
is*Nodetype guard functions have been updated to acceptnull | undefinedfor easier chaining. Ruby generates union type signatures in RBS files. Rust adds a newunion_types.rsfile with enum types and conversion functions for each union.With these type improvements the linter, formatter, and language server code has been simplified to use
is*Nodetype guards instead of manual.type === "AST_*"string checks. This removes numerousas anyandas *Nodecasts that were previously needed, making the code more type-safe and readable.