Skip to content

Parser: Store parser options on ParseResult#1190

Merged
marcoroth merged 4 commits intomainfrom
parse-result-with-options
Feb 19, 2026
Merged

Parser: Store parser options on ParseResult#1190
marcoroth merged 4 commits intomainfrom
parse-result-with-options

Conversation

@marcoroth
Copy link
Owner

@marcoroth marcoroth commented Feb 16, 2026

This pull request updates the ParseResult in all bindings to store the parser_options_T that were use to parse the document on the ParseResult itself.

Ruby

result = Herb.parse("<div><%= hello %></div>")
result.options
#=> #<Herb::ParserOptions strict=true track_whitespace=false analyze=true>
result = Herb.parse("<div><%= hello %></div>", strict: false, track_whitespace: true)
result.options.strict             #=> false
result.options.track_whitespace   #=> true
result.options.analyze            #=> true

JavaScript

const result = parse("<div><%= hello %></div>")
result.options
// ParserOptions { strict: true, track_whitespace: false, analyze: true }

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 16, 2026

npx https://pkg.pr.new/@herb-tools/formatter@1190
npx https://pkg.pr.new/@herb-tools/language-server@1190
npx https://pkg.pr.new/@herb-tools/linter@1190

commit: 464a352

@github-actions
Copy link

github-actions bot commented Feb 16, 2026

🌿 Interactive Playground and Documentation Preview

A preview deployment has been built for this pull request. Try out the changes live in the interactive playground:


🌱 Grown from commit 464a352


✅ Preview deployment has been cleaned up.

@marcoroth marcoroth force-pushed the parse-result-with-options branch from 5022124 to 4d35a51 Compare February 19, 2026 23:33
@marcoroth marcoroth merged commit 0a3aaf4 into main Feb 19, 2026
30 of 31 checks passed
@marcoroth marcoroth deleted the parse-result-with-options branch February 19, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants