Linter: Implement html-allowed-script-type rule#1201
Merged
marcoroth merged 3 commits intomarcoroth:mainfrom Feb 20, 2026
Merged
Linter: Implement html-allowed-script-type rule#1201marcoroth merged 3 commits intomarcoroth:mainfrom
html-allowed-script-type rule#1201marcoroth merged 3 commits intomarcoroth:mainfrom
Conversation
github-actions
bot
added
documentation
markokajzer
force-pushed
the
marko/allowed-script-type
branch
from
a705a9a to
40760aa
Compare
marcoroth
reviewed
Feb 18, 2026
Owner
There was a problem hiding this comment.
Hey @markokajzer, thanks for taking this on!
-
Sadly we cannot really add custom configuration for linter rules yet, this is something we should add in the future though.
That said, I guess we can leave it for now, keep the
ALLOW_BLANKconst in the rule for later, but maybe add a// TODOcomment so know that it needs some work.I'd also say since it's not configurable, that we set
ALLOW_BLANKtotrueto begin with, so it's not as aggressive.Edit: I opened #1204 to track this
-
Yeah, I think we can keep this separate. There is also #162 we can implement separately.
Contributor
Author
|
added comment and flipped the switch 👍 |
markokajzer
force-pushed
the
marko/allowed-script-type
branch
from
382bc3f to
055cb25
Compare
marcoroth
changed the title
html-allowed-script-type rulehtml-allowed-script-type rule
marcoroth
approved these changes
Feb 19, 2026
Owner
marcoroth
left a comment
marcoroth
left a comment
There was a problem hiding this comment.
Thank you so much @markokajzer! 🙏🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #554
questions
disallow_inline_scriptsoption? It kind of goes a bit further than just checking the types. Maybe it should be its own rule?