Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces
clang-tidyto enhance code quality and consistency.High-Level Updates
.clang-tidy: Added a comprehensive set ofclang-tidychecks to enforce best practices and catch potential issues.Makefile: Updated to include atidycommand. Also DRY-ed up theproject_filesandextension_filesused for formatting, linting and now tidying.bin/tidy: Added a bin script that can be used to run theclang-tidychecked defined in the Makefile..github/workflows/test.yml: Added a new job to runbin/tidyon the codebase as part of the CI pipeline.Brewfile: Addedllvmto ensureclang-tidyis available in the development environment.README.md: Updated to include instructions for installingclang-tidyand clarified its usage in the project.Codebase Refinements detected by
clang-tidysize_tinstead ofintfor sizes and indices, improving type safety and consistency. All of these usages deal with numbers that are always positive, which removes the need for a signedint.src/include/macros.hfor readability.switchcases where we didn't have a default or the same statements.Note
For now we disabled the
bugprone-suspicious-realloc-usagerule, but I'll follow up with a pull request to enable this rule and to address the valid warnings.