Simplify Lexer by removing the lexer state#34
Merged
Conversation
This was referenced Feb 16, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the lexer by removing its state, as I think the parser should handle most of what the lexer has been doing thus far.
I think the lexer is now much easier to understand and maintain.
With that, we also added new tokens such as
TOKEN_IDENTIFIER,TOKEN_LT,TOKEN_SLASH,TOKEN_EQUALS,TOKEN_QUOTE,TOKEN_DASH,TOKEN_UNDERSCORE,TOKEN_EXCLAMATION,TOKEN_COLON,TOKEN_PERCENT, andTOKEN_ERRORand removed the ones we don't need anymore.I also added a bunch of new tests and updated the old ones to match the new tokens. With this pull request we are now passing all tests without any skips!