Printer: Move IdentityPrinter implementation out of Printer#435
Merged
Printer: Move IdentityPrinter implementation out of Printer#435
IdentityPrinter implementation out of Printer#435Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request moves the concrete implantation of the
IdentityPrinterinto theIdentityPrinterclass, so that the abstractPrintersuper class only handles the visiting/printing.The idea is that you should overwrite the methods for the nodes you want to handle in your
Printer. If you don't overwrite anything it shouldn't print anything.If you want to just fallback to the default, you can extend from the
IdentityPrinterclass and then overwrite the methods you want to handle differently.