Engine: Add support for customizing escape functions #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
force-pushed
the
engine-customizable-escape-functions
branch
from
c3021ab to
c1ad7a4
Compare
marcoroth
changed the title
marcoroth
added a commit
to marcoroth/reactionview
that referenced
this pull request
Dec 4, 2025
Depends on marcoroth/herb#720 Resolves #12 --------- Co-authored-by: Koji NAKAMURA <kozy4324@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
Herb::Engineto accept newattrfunc,jsfunc, andcssfuncoptions.This enables ReActionView (and Rails) to customize these escape functions (similar to how it's already customizing
escapefunc) so that we can avoid the double escaping.Since ActionView uses
ActionView::OutputBufferinstead ofStringit would end up be double-escaped if we didn't allow it to be customized and set to""(see marcoroth/reactionview#12).Enables marcoroth/reactionview#53