Use single quote string if it contains double quotes#2
Merged
marcoroth merged 1 commit intomarcoroth:mainfrom Jan 8, 2023
Merged
Use single quote string if it contains double quotes#2marcoroth merged 1 commit intomarcoroth:mainfrom
marcoroth merged 1 commit intomarcoroth:mainfrom
Conversation
dennispaagman
force-pushed
the
comments_double_quotes
branch
from
827d035 to
354ef01
Compare
dennispaagman
changed the title
Owner
|
That looks good to me, thank you @djfpaagman! 🚀 |
Owner
|
also available on the hosted version now 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that double quotes are not handled properly, this fixes that by using single quotes if the string contains any double quotes.
Before:
After:
