Enhance RubyAnalyzer to detect instance_methods and more#72
Merged
Conversation
marcoroth
changed the title
RubyAnalyzer to also detect more thingsRubyAnalyzer to detect instance_methods and more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances
Phlexing::RubyAnalyzerto also detectconst,callsandinstance_methods.Detecting
instance_methodscould to be useful if we want to include certain modules based on the methods used in the template. For example we could detect Rails helpers this way and include the appropriate ones in the generated code.Detecting
constswithin the template could be useful down the road if we are dealing with the rendering of other components in the template and if we want to do some checks around it.I'm not sure yet what we could do with the
calls, but I think it might be useful to have in any case.