Skip to content

now use proper table based parameter for wifi.ap.setip#106

Merged
marcoskirsch merged 1 commit intomarcoskirsch:masterfrom
Godzil:fix_ap_setip
Sep 3, 2017
Merged

now use proper table based parameter for wifi.ap.setip#106
marcoskirsch merged 1 commit intomarcoskirsch:masterfrom
Godzil:fix_ap_setip

Conversation

@Godzil
Copy link
Copy Markdown
Contributor

@Godzil Godzil commented Sep 3, 2017

Use a proper table for wifi.ap.setip instead of a string.

This is related with #103 where the NodeMCU's wifi object changed part of it's API.

@marcoskirsch marcoskirsch merged commit 28fbb6e into marcoskirsch:master Sep 3, 2017
@geschwaerzler
Copy link
Copy Markdown
Contributor

Hi Marcos,

shouldn't it be:

conf.wifi.accessPoint.net.ip = {}
conf.wifi.accessPoint.net.ip = "192.168.111.1"
conf.wifi.accessPoint.net.netmask="255.255.255.0"
conf.wifi.accessPoint.net.gateway="192.168.111.1"

@geschwaerzler
Copy link
Copy Markdown
Contributor

sorry, shouldn't it be:

conf.wifi.accessPoint.net = {}
conf.wifi.accessPoint.net.ip = "192.168.111.1"
conf.wifi.accessPoint.net.netmask="255.255.255.0"
conf.wifi.accessPoint.net.gateway="192.168.111.1"

or alternatively
conf.wifi.accessPoint.net = {
ip = "192.168.111.1",
netmask="255.255.255.0",
gateway="192.168.111.1" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants