Skip to content

Add current time indicators to schedules view minus one bug in Desktop WEB UI#202

Merged
marcpope merged 3 commits intomarcpope:mainfrom
c0dr1ver:feature/now-time
Apr 24, 2026
Merged

Add current time indicators to schedules view minus one bug in Desktop WEB UI#202
marcpope merged 3 commits intomarcpope:mainfrom
c0dr1ver:feature/now-time

Conversation

@c0dr1ver
Copy link
Copy Markdown
Contributor

@c0dr1ver c0dr1ver commented Apr 24, 2026

Summary

  • Add a user-timezone-aware current time marker to the schedules day view
  • Add a vertical current time marker to the Load By Hour chart for Today
  • Label both markers with the current time using the user's configured time format
  • Fix bug with "Recently complete - Duration" in index

Testing

  • php -l src/Views/schedules/week.php
  • [+] Tested on Docker
  • [+] Tested on bare metal
  • Agent changes tested on Linux
  • Agent changes tested on Windows

@c0dr1ver
Copy link
Copy Markdown
Contributor Author

image image

@c0dr1ver
Copy link
Copy Markdown
Contributor Author

image

@c0dr1ver c0dr1ver changed the title Add current time indicators to schedules view Add current time indicators to schedules view minus one bug in Desktop WEB UI Apr 24, 2026
@marcpope
Copy link
Copy Markdown
Owner

Thanks @c0dr1ver — read through the diff, this is solid work.

A few notes for visibility (none of them blocking):

  • The duration fix is a real bug catch. The old gmdate('i\m s\s', $sec) silently truncates the hour component, so any job ≥ 1h was rendering wrong. Glad this is included.
  • The "Now" markers look great in your screenshots — appreciate that they're server-rendered (clean, no JS dependency) and theme-aware via var(--bs-danger). Tradeoff is they're stale after page-load, which is fine for a passive indicator.
  • The errors-count broadening (log errors + failed jobs + unresolved offline/missed-schedule alerts) is a meaningful conceptual change to the existing "Errors" tile. I'd want to call that out in release notes when it ships so existing dashboards don't surprise people with a sudden bump.

One small process ask for next time: if you can split unrelated changes into separate PRs (markers, error-count expansion, duration fix), it makes review and bisecting much easier. Not blocking — happy to take this as-is.

Timing: I just shipped v2.29.1 (new Docker agent image + restore reporting fixes) and want to bake feedback on those changes for a few days before the next release. Holding this PR open and will merge it into the next release window once we've confirmed the current set is stable. Thanks for being patient.

@marcpope marcpope merged commit 4a3c371 into marcpope:main Apr 24, 2026
@c0dr1ver
Copy link
Copy Markdown
Contributor Author

Thanks for the detailed review.

That all sounds perfectly reasonable. I’ll make sure to split unrelated changes into separate PRs going forward to keep things easier to review and bisect.

Happy to wait for the next release window

@c0dr1ver
Copy link
Copy Markdown
Contributor Author

c0dr1ver commented Apr 25, 2026

Hi @marcpope

I did an additional verification of the changes related to error visibility on the dashboard and can confirm that the fix works correctly on my production server.

In the screenshots below, you can see an example where one of my agents produced an error (all good - I temporarily pointed it to a dev branch for testing). The error is clearly visible in the logs, but before the fix it was not reflected on the main dashboard - neither in the histogram nor in the ERRORS (24H) widget.

Screenshot from 2026-04-25 20-57-28 Screenshot from 2026-04-25 20-55-02

The final screenshot shows the state after applying the changes, where the error is now correctly accounted for.

Screenshot from 2026-04-25 20-49-19

Let me know if you’d like me to test any additional edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants