Add current time indicators to schedules view minus one bug in Desktop WEB UI#202
Add current time indicators to schedules view minus one bug in Desktop WEB UI#202marcpope merged 3 commits intomarcpope:mainfrom
Conversation
|
Thanks @c0dr1ver — read through the diff, this is solid work. A few notes for visibility (none of them blocking):
One small process ask for next time: if you can split unrelated changes into separate PRs (markers, error-count expansion, duration fix), it makes review and bisecting much easier. Not blocking — happy to take this as-is. Timing: I just shipped v2.29.1 (new Docker agent image + restore reporting fixes) and want to bake feedback on those changes for a few days before the next release. Holding this PR open and will merge it into the next release window once we've confirmed the current set is stable. Thanks for being patient. |
|
Thanks for the detailed review. That all sounds perfectly reasonable. I’ll make sure to split unrelated changes into separate PRs going forward to keep things easier to review and bisect. Happy to wait for the next release window |
|
Hi @marcpope I did an additional verification of the changes related to error visibility on the dashboard and can confirm that the fix works correctly on my production server. In the screenshots below, you can see an example where one of my agents produced an error (all good - I temporarily pointed it to a dev branch for testing). The error is clearly visible in the logs, but before the fix it was not reflected on the main dashboard - neither in the histogram nor in the ERRORS (24H) widget.
The final screenshot shows the state after applying the changes, where the error is now correctly accounted for.
Let me know if you’d like me to test any additional edge cases. |






Summary
Testing
php -l src/Views/schedules/week.php