Support for registration messaging backends other than SMTP (e.g., local file)#615
Merged
Support for registration messaging backends other than SMTP (e.g., local file)#615
Conversation
marcua
commented
Jun 29, 2025
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
Owner
Author
There was a problem hiding this comment.
Remove, we test either/or logic farther down
marcua
commented
Jun 29, 2025
marcua
commented
Jun 29, 2025
marcua
commented
Jun 29, 2025
* Stabilize snapshot tests by migrating LocalStack -> Minio * Remove localstack data * Separate docker setup for macOS vs Linux/CI
This is Phase 1 of investigating CI snapshot test failures. Adds extensive logging to identify timing and storage issues: MinIO setup (tests/run_minio.sh): - Timestamped container lifecycle logging - Detailed S3 API connectivity testing - Environment detection and networking diagnostics - Comprehensive readiness verification Snapshot storage (src/server/snapshots/storage.rs): - S3 connection setup logging - Upload/download operation timing - Compression ratio and performance metrics - Detailed error context for failures Test progression (tests/e2e_tests/snapshot_tests.rs): - Step-by-step test state logging - Snapshot count and timing verification - Sleep duration and timing tracking - Database modification confirmation This logging will help identify: - MinIO container startup issues - S3 operation failures - Timing race conditions - Snapshot creation/pruning problems 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Adds explicit log crate dependency to Cargo.toml to resolve compilation error in snapshot storage logging code. The log crate was being used transitively through env_logger but needs to be explicitly declared for direct usage. Fixes compilation error: error[E0432]: unresolved import `log` 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolves formatting and linting issues identified by make lint: - Remove trailing whitespace from snapshot storage logging - Fix clippy::len_zero warning (use \!is_empty() instead of len() > 0) - Auto-format code with cargo fmt for consistent style All tests pass and linting is now clean. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Enhanced snapshot automation logging with timestamps and detailed pruning info - Added pre-restore snapshot verification to detect race conditions - Added restore endpoint logging to track snapshot availability - Timestamps and snapshot IDs logged at every critical point This will help identify if automated snapshots are triggering pruning between test listing and restoration attempts.
marcua
commented
Jul 2, 2025
| )?; | ||
| thread::sleep(time::Duration::from_secs(4)); | ||
|
|
||
| // There are 3 max_snapshots, so let's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #217 and generally makes integration testing easier.
As part of this, resolved two tangential issues that made tests fail:
--network host), it might be unnecessary to have left LocalStack, but MinIO also seems like a more direct solution to the S3-compatible storage problem than the more general-purpose LocalStack.