Merged
Conversation
- scripts/pre-commit.sh: lightweight hook checking gofmt (staged files only), go vet, and go build; exits non-zero on any failure - Makefile: add install-hooks target (symlinks hook into .git/hooks/) - README: add Development section documenting make install-hooks Skipped: go test (too slow per-commit), golangci-lint (no local config yet). Both remain available via make check / CI.
On the first of the month, daily estimate = all requests / 1 day, which can legitimately exceed the daily allocation. The assertion was too strict; percentages > 100% are valid over-budget signals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a lightweight git pre-commit hook for nightshift.
Files
scripts/pre-commit.sh— the hook scriptMakefile—make install-hookstarget (symlinks into.git/hooks/)README.md— Development section with install instructionsChecks
gofmtgo vetgo buildNot included:
go test(too slow per-commit) andgolangci-lint(no local config yet — both still run in CI).Install
To bypass:
git commit --no-verifyTested
Hook ran on its own commit cleanly. Also verified it catches: