Merged
Conversation
The custom navbar-sidebar CSS changed flex-direction to column (stacking panels vertically) but Infima's .navbar-sidebar__items--show-secondary rule still applied transform: translateX(-83vw), sliding the entire column off-screen when on a docs page. Fix: override the translateX to none. We're using display:none/flex via the [inert] attribute to toggle panels — no slide animation needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On mobile, the hamburger menu opened but the sidebar appeared completely empty — no doc links visible.
Root Cause
The custom CSS in
custom.csschanged.navbar-sidebar__itemsto useflex-direction: column(stacking the primary and secondary panels vertically). However, Infima's default CSS for.navbar-sidebar__items--show-secondarystill appliedtransform: translateX(-83vw)— designed for the default horizontal side-by-side layout to slide between panels.With
flex-direction: column, this horizontal translate moved the entire items container off the left edge of the sidebar, making all content invisible.Fix
Add
.navbar-sidebar__items--show-secondary { transform: none !important; }to cancel the slide. The[inert]attribute +display: none/flexCSS already handles showing/hiding the correct panel — no slide animation needed.Testing
Verified with Playwright on iPhone 12 viewport: doc links now appear correctly in the mobile sidebar.