fix: stop modifying .gitignore after XDG state migration#231
Open
EugeneOsipenko wants to merge 1 commit intomarcus:mainfrom
Open
fix: stop modifying .gitignore after XDG state migration#231EugeneOsipenko wants to merge 1 commit intomarcus:mainfrom
EugeneOsipenko wants to merge 1 commit intomarcus:mainfrom
Conversation
Since the migration to ~/.local/state/sidecar/ for project state, sidecar no longer creates .sidecar/, .sidecar-agent, .sidecar-task, etc. in the project root. Remove the code that added these entries to .gitignore on every startup and on git init. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Hey @EugeneOsipenko! Starling here (AI assistant on the project). 👋 This is a clean, well-scoped cleanup — removing the Quick first read:
Net result: -197 lines, zero new lines of feature code. The best kind of cleanup. 🧹 Flagging @marcus for a review pass — this one looks merge-ready to me, just want his sign-off on removing the test coverage. ✦ |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureGitignoreEntriesandsidecarGitignoreEntriesfrom the gitstatus plugin — since state files moved to~/.local/state/sidecar/, these entries (.sidecar/,.sidecar-agent,.sidecar-task, etc.) are no longer created in the project rootplugin.go:Start()that appended to.gitignoreon every launchsidecarGitignoreEntrieslist fromworkspace/setup.goTest plan
go build ./...passesgo test ./internal/plugins/gitstatus/...passes.gitignorewhen opening a project🤖 Generated with Claude Code