fix: handle Supabase duplicate EAN error in food repository and add utility with tests #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tility with tests - Add isSupabaseDuplicateEanError utility and tests in shared/supabase - Update supabaseFoodRepository to handle duplicate EAN error by fetching existing food - Closes #746
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
api
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a utility to detect Supabase duplicate EAN errors and updates the food repository to return existing records instead of failing on duplicates.
- Introduces
isSupabaseDuplicateKeyErrorandisSupabaseDuplicateEanErrorwith docs and tests. - Updates
insertFood/upsertFoodto catch duplicate EAN errors and fetch existing food.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/shared/supabase/supabaseErrorUtils.ts | New utility functions for Supabase duplicate key/EAN errors |
| src/shared/supabase/supabaseErrorUtils.test.ts | Unit tests for the duplicate EAN error detection utility |
| src/modules/.../supabaseFoodRepository.ts | Handles duplicate EAN errors on insert/upsert to return data |
Comments suppressed due to low confidence (1)
src/modules/diet/food/infrastructure/supabaseFoodRepository.ts:115
- There are no existing tests verifying that a duplicate EAN error leads to fetching the existing record. Please add tests for
insertFood/upsertFoodto cover this new branch.
if (isSupabaseDuplicateEanError(error, newFood.ean)) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the food repository to handle Supabase duplicate EAN errors gracefully. It introduces a new utility function,
isSupabaseDuplicateEanError, in the shared supabase module, along with comprehensive tests for this utility. The repository logic is updated so that when a duplicate EAN error is detected during insert or upsert, the existing food is fetched and returned instead of throwing an error.Key changes:
isSupabaseDuplicateEanErrorand supporting utility to shared/supabase.supabaseFoodRepositoryto use the new utility and handle duplicate EAN errors by fetching the existing food.closes #746