Refactor CopyLastDayButton: show only days with registered diet and add summary copy list #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et, add summary list and copy action - Replace datepicker with a list of days with registered diet in CopyLastDayButton - Show summary and copy button for each available day - Add fallback message when no days are available to copy - Add date-fns dependency for date formatting - Update styles and docs for new behavior
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
complexity-low
…onents, use Accessor/Setter for modal state
…rate components for clarity
…nd improve error context propagation - Introduce WeightNotFoundForDayError and MacroTargetNotFoundForDayError in macroTarget.ts - Enhance errorMessageHandler to include all custom error properties in toast context
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the “copy last day” workflow by replacing the datepicker with a list of days that have diets, adding per-day summaries and copy actions, and providing a no-data fallback.
- Replaces the datepicker UI with a scrollable list of
PreviousDayCardentries. - Moves copy logic into
CopyLastDayModal/CopyLastDayButtonand adds loading state. - Updates
DayMacrosto use a memoized error-aware result and addsdate-fnsfor formatting.
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sections/day-diet/components/CopyLastDayButton.tsx | Removes datepicker, adds CopyLastDayModal integration |
| src/sections/day-diet/components/CopyLastDayModal.tsx | New modal listing only days with registered diets |
| src/sections/day-diet/components/PreviousDayCard.tsx | Displays formatted date and opens details modal |
| src/sections/day-diet/components/PreviousDayCardActions.tsx | Separates “view” and “copy” buttons with loading state |
| src/sections/day-diet/components/PreviousDayDetailsModal.tsx | New component showing daily summary |
| src/sections/day-diet/components/DayMacros.tsx | Refactors to createMemo with structured error result |
| src/modules/diet/macro-target/application/macroTarget.ts | Adds custom error classes for weight/macro-target |
| src/modules/toast/domain/errorMessageHandler.ts | Includes custom error properties in toast context |
| package.json | Adds date-fns dependency |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
src/sections/day-diet/components/DayMacros.tsx:15
- [nitpick] The name 'macroSignals' suggests a reactive signal but this memo returns macro data; consider renaming to 'macroData' or 'macroResult' for clarity.
const macroSignals = createMemo(() => {
src/sections/day-diet/components/CopyLastDayModal.tsx:25
- Add unit tests for
CopyLastDayModalto verify the fallback message whenpreviousDaysis empty and correct rendering of cards when days are available.
<Show
…day found to copy
…usDayCard using MacroNutrientsView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
CopyLastDayButtoncomponent to improve the user experience when copying a previous days diet:date-fnsdependency for date formatting.This change streamlines the copy workflow, making it easier for users to find and copy relevant days. No breaking changes are introduced.
closes #774