Skip to content

chore(repo): restore registry drift check and refresh AGENTS docs#328

Merged
marcusrbrown merged 2 commits into
mainfrom
chore/refresh-agents-ci-drift
May 1, 2026
Merged

chore(repo): restore registry drift check and refresh AGENTS docs#328
marcusrbrown merged 2 commits into
mainfrom
chore/refresh-agents-ci-drift

Conversation

@marcusrbrown
Copy link
Copy Markdown
Owner

Summary

  • restore the CI registry drift step to run bun run registry:drift, keeping generated-output drift detection separate from source registry validation
  • refresh the root AGENTS.md snapshot for the released v2.7.0 repo state, including plugin export shape, command layout, hook naming, and current test counts
  • refresh docs/AGENTS.md for Astro 6 and shared frontmatter parsing, and pin the workflow/package registry command contract in unit tests

Testing

  • bun test tests/unit/plugin.test.ts
  • bun run typecheck
  • bun run registry:validate
  • bun run registry:drift
  • bun run docs:build

Split registry validation from generated-output drift detection so CI still catches stale registry artifacts. Refresh the root and docs AGENTS snapshots to match the released v2.7.0 repo state and pin the workflow contract in unit tests.
Copy link
Copy Markdown
Collaborator

@fro-bot fro-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS

Clean PR that restores a CI registry drift check via an npm script, pins the contract in unit tests, and refreshes AGENTS.md documentation to match current codebase state.

Blocking issues

None

Non-blocking concerns

  • Test naming: The extended CI smoke test now asserts both plugin loading and registry:drift presence, but the test name 'CI smoke test loads the default plugin export' doesn't reflect the added concern. Consider renaming to something like 'CI workflow script contract' or splitting into a dedicated test. Pure naming nit — not blocking.
  • Test brittleness: The package exposes distinct registry validation and drift commands test pins exact script values (e.g., 'bun scripts/build-registry.ts --validate-only'). This is intentional contract testing, but anyone changing those scripts will need to update both the test and CI simultaneously. Acceptable tradeoff given the PR's stated goal of keeping these in sync.

Missing tests

None — the PR adds the right tests for the new contract.

Risk assessment

LOW — No production code changes. The workflow now calls bun run registry:drift instead of bun scripts/generate-registry.ts --check, which resolves to the identical command via the new package.json script. The tests validate this contract. Documentation updates are accuracy corrections that bring AGENTS.md in line with current source (verified: hook name is experimental.chat.system.transform, SystematicPlugin is a const, 15 unit test files exist, commands/ dir is removed, SKILL_FRONTMATTER_FIELDS exists at line 48). Zero blast radius.


Run Summary
Field Value
Event pull_request
Repository marcusrbrown/systematic
Run ID 25200900297
Cache hit
Session ses_21e68af22ffev5LznFlvoM7v19

@marcusrbrown
Copy link
Copy Markdown
Owner Author

Test naming: The extended CI smoke test now asserts both plugin loading and registry:drift presence, but the test name 'CI smoke test loads the default plugin export' doesn't reflect the added concern.

Addressed: renamed the test to CI smoke test validates the workflow plugin export and registry drift contract so the name matches the assertions it now covers.

Copy link
Copy Markdown
Collaborator

@fro-bot fro-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS

Previous non-blocking concern addressed: the test is now renamed to 'CI smoke test validates the workflow plugin export and registry drift contract' which accurately describes its assertions. No new issues introduced in the follow-up commit.

Blocking issues

None

Non-blocking concerns

None — the prior naming concern has been resolved.

Missing tests

None

Risk assessment

LOW — Identical to prior assessment. No production code changes, CI script refactoring documented and tested, AGENTS.md refreshed to match current source state.


Run Summary
Field Value
Event pull_request
Repository marcusrbrown/systematic
Run ID 25201130469
Cache hit
Session ses_21e68af22ffev5LznFlvoM7v19

@marcusrbrown marcusrbrown merged commit ac8c336 into main May 1, 2026
11 checks passed
@marcusrbrown marcusrbrown deleted the chore/refresh-agents-ci-drift branch May 1, 2026 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants