chore(repo): restore registry drift check and refresh AGENTS docs#328
Conversation
Split registry validation from generated-output drift detection so CI still catches stale registry artifacts. Refresh the root and docs AGENTS snapshots to match the released v2.7.0 repo state and pin the workflow contract in unit tests.
fro-bot
left a comment
There was a problem hiding this comment.
Verdict: PASS
Clean PR that restores a CI registry drift check via an npm script, pins the contract in unit tests, and refreshes AGENTS.md documentation to match current codebase state.
Blocking issues
None
Non-blocking concerns
- Test naming: The extended CI smoke test now asserts both plugin loading and registry:drift presence, but the test name
'CI smoke test loads the default plugin export'doesn't reflect the added concern. Consider renaming to something like'CI workflow script contract'or splitting into a dedicated test. Pure naming nit — not blocking. - Test brittleness: The
package exposes distinct registry validation and drift commandstest pins exact script values (e.g.,'bun scripts/build-registry.ts --validate-only'). This is intentional contract testing, but anyone changing those scripts will need to update both the test and CI simultaneously. Acceptable tradeoff given the PR's stated goal of keeping these in sync.
Missing tests
None — the PR adds the right tests for the new contract.
Risk assessment
LOW — No production code changes. The workflow now calls bun run registry:drift instead of bun scripts/generate-registry.ts --check, which resolves to the identical command via the new package.json script. The tests validate this contract. Documentation updates are accuracy corrections that bring AGENTS.md in line with current source (verified: hook name is experimental.chat.system.transform, SystematicPlugin is a const, 15 unit test files exist, commands/ dir is removed, SKILL_FRONTMATTER_FIELDS exists at line 48). Zero blast radius.
Run Summary
| Field | Value |
|---|---|
| Event | pull_request |
| Repository | marcusrbrown/systematic |
| Run ID | 25200900297 |
| Cache | hit |
| Session | ses_21e68af22ffev5LznFlvoM7v19 |
Addressed: renamed the test to |
fro-bot
left a comment
There was a problem hiding this comment.
Verdict: PASS
Previous non-blocking concern addressed: the test is now renamed to 'CI smoke test validates the workflow plugin export and registry drift contract' which accurately describes its assertions. No new issues introduced in the follow-up commit.
Blocking issues
None
Non-blocking concerns
None — the prior naming concern has been resolved.
Missing tests
None
Risk assessment
LOW — Identical to prior assessment. No production code changes, CI script refactoring documented and tested, AGENTS.md refreshed to match current source state.
Run Summary
| Field | Value |
|---|---|
| Event | pull_request |
| Repository | marcusrbrown/systematic |
| Run ID | 25201130469 |
| Cache | hit |
| Session | ses_21e68af22ffev5LznFlvoM7v19 |
Summary
bun run registry:drift, keeping generated-output drift detection separate from source registry validationAGENTS.mdsnapshot for the releasedv2.7.0repo state, including plugin export shape, command layout, hook naming, and current test countsdocs/AGENTS.mdfor Astro 6 and shared frontmatter parsing, and pin the workflow/package registry command contract in unit testsTesting
bun test tests/unit/plugin.test.tsbun run typecheckbun run registry:validatebun run registry:driftbun run docs:build