Skip to content

feat: expose orthographic camera projection#339

Merged
hannojg merged 1 commit into
margelo:mainfrom
balderfer:balderfer/add-orthographic-camera-projection
May 9, 2026
Merged

feat: expose orthographic camera projection#339
hannojg merged 1 commit into
margelo:mainfrom
balderfer:balderfer/add-orthographic-camera-projection

Conversation

@balderfer
Copy link
Copy Markdown
Contributor

@balderfer balderfer commented May 6, 2026

Description

Filament already supports orthographic cameras through Camera::setProjection(Camera::Projection::ORTHO, ...), but react-native-filament currently only exposes the perspective helpers through the JS camera wrapper.

This PR bridges that existing Filament API so React Native callers can configure an orthographic projection without dropping down to native code.

Changes

  • Adds camera.setOrthographicProjection(left, right, bottom, top, near, far) to the native Camera wrapper.
  • Registers the new method with the JSI hybrid object.
  • Adds the method to the RNFCamera TypeScript interface.

Testing

  • Ran yarn check-all from package/.
  • Verified C++ formatting ran after installing the missing clang-format local dependency.
  • Verified ESLint and TypeScript completed successfully.

@balderfer balderfer marked this pull request as ready for review May 6, 2026 16:23
Copy link
Copy Markdown
Member

@hannojg hannojg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@hannojg hannojg merged commit 1724aae into margelo:main May 9, 2026
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants