-
-
Notifications
You must be signed in to change notification settings - Fork 38
feat: Migrate library to a react-native-nitro-modules
#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| # TODO: Should be customizable in package.json. | ||
| # Used to create comparable benchmark results | ||
| performance_mode = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you weren't aware. You can set sqlite's threading mode per connection when compiled with SQLITE_THREADSAFE set to either 1 or 2:
The SQLITE_OPEN_NOMUTEX and SQLITE_OPEN_FULLMUTEX flags to sqlite3_open_v2() can also be used to adjust the threading mode of individual database connections at run-time.
From: https://www.sqlite.org/compile.html#threadsafe
Additionally here (section 4): https://www.sqlite.org/threadsafe.html
react-native-nitro-modules)react-native-nitro-modules
|
After many months of migrating, testing and benchmarking, i am finally confident to merge this PR! 🚀 Both building the library as well as performance has been thoroughly tested and works both on old and new arch, both in bridgeless and non-bridgeless mode. The migration to cc @mrousavy |
|
@vhakulinen also thanks for your input! I will hopefully address your concerns and issues in future PRs in |
This PR migrates this library to a Nitro module using the new
react-native-nitro-modules.This PR includes changes from the following Sub-PRs that were needed to make this work: