Skip to content

Conversation

@chrispader
Copy link
Member

@chrispader chrispader commented Sep 11, 2024

This PR migrates this library to a Nitro module using the new react-native-nitro-modules.

This PR includes changes from the following Sub-PRs that were needed to make this work:


# TODO: Should be customizable in package.json.
# Used to create comparable benchmark results
performance_mode = 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you weren't aware. You can set sqlite's threading mode per connection when compiled with SQLITE_THREADSAFE set to either 1 or 2:

The SQLITE_OPEN_NOMUTEX and SQLITE_OPEN_FULLMUTEX flags to sqlite3_open_v2() can also be used to adjust the threading mode of individual database connections at run-time.

From: https://www.sqlite.org/compile.html#threadsafe

Additionally here (section 4): https://www.sqlite.org/threadsafe.html

@chrispader chrispader changed the title Migrate library to a Nitro module (react-native-nitro-modules) feat: Migrate library to a react-native-nitro-modules Nov 13, 2024
@chrispader
Copy link
Member Author

After many months of migrating, testing and benchmarking, i am finally confident to merge this PR! 🚀

Both building the library as well as performance has been thoroughly tested and works both on old and new arch, both in bridgeless and non-bridgeless mode.

The migration to react-native-modules will be a great improvement in code readability, DX, maintenance and hopefully also performance! ⚡

cc @mrousavy

@chrispader
Copy link
Member Author

@vhakulinen also thanks for your input! I will hopefully address your concerns and issues in future PRs in react-native-nitro-sqlite

@chrispader chrispader merged commit f37bc1f into main Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants