feat: add one-shot sign/verify and Ed class docs #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the missing crypto.sign() and crypto.verify() one-shot functions that match the Node.js API. These complement the existing streaming createSign()/createVerify() API. - Add sign() and verify() with sync and callback overloads - Add comprehensive tests for one-shot sign/verify - Update coverage docs
Updates ed25519.mdx to document the Ed class which provides a simpler API inspired by @noble/curves. This is in addition to the standard Node.js compatible API. - Document Ed class constructor and supported curve types - Add examples for key generation, signing, verifying - Add X25519 shared secret (Diffie-Hellman) examples - Include methods reference table - Update Node.js API examples to use one-shot sign/verify
Contributor
🤖 End-to-End Test Results - AndroidStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
Contributor
🤖 End-to-End Test Results - iOSStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issues #888 and #889:
Issue #888: Missing
crypto.sign()andcrypto.verify()functionsAdded the missing one-shot
sign()andverify()functions that match the Node.js API. These complement the existing streamingcreateSign()/createVerify()API.Changes:
sign(algorithm, data, key, callback?)with sync and callback overloadsverify(algorithm, data, key, signature, callback?)with sync and callback overloadsIssue #889: Ed class documentation
Updated ed25519.mdx to document the
Edclass which provides a simpler API inspired by@noble/curves. This is in addition to the standard Node.js compatible API.Changes:
Closes #888
Closes #889