fix: auto-download OpenSSL.xcframework during pod install#895
Merged
Conversation
CocoaPods skips prepare_command for :path pods, which is how React Native native modules are installed. This caused OpenSSL.xcframework to not be downloaded, resulting in 'openssl/bio.h' file not found errors. The fix adds Ruby code that runs during podspec evaluation to download OpenSSL if missing, before any build phases run. Also updates OpenSSL to 3.6.0001 and adds react-native-mmkv to the example app for testing compatibility. Fixes #882
CocoaPods skips prepare_command for :path pods, which is how React Native native modules are installed. This caused OpenSSL.xcframework to not be downloaded, resulting in 'openssl/bio.h' file not found errors. The fix adds Ruby code that runs during podspec evaluation to download OpenSSL if missing, before any build phases run. Uses -sSfL curl flags for better error handling (show errors, fail on HTTP errors). Also: - Update to OpenSSL 3.6.0001 - Upgrade to Nitro Modules 0.33.2 and nitrogen (renamed from nitro-codegen) - Add bun catalog for centralized nitro dependency versioning - Fix Buffer.isBuffer() tests (instanceof fails across module boundaries) - Add react-native-mmkv to example app for compatibility testing Fixes #882
Contributor
🤖 End-to-End Test Results - AndroidStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
Contributor
🤖 End-to-End Test Results - iOSStatus: ✅ Passed 📸 Final Test ScreenshotScreenshot automatically captured from End-to-End tests and will expire in 30 days This comment is automatically updated on each test run. |
Create .github/actions/setup-bun composite action to manage bun version in one place (1.3.8). Update all workflows to use the shared action. Bun 1.3+ is required for catalog support in package.json.
The path was pointing to root node_modules but bun hoists example dependencies to example/node_modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CocoaPods skips
prepare_commandfor:pathpods, which is how React Native native modules are installed. This causedOpenSSL.xcframeworkto not be downloaded, resulting in'openssl/bio.h' file not founderrors.Changes
Core Fix
-sSfLcurl flags for better error handling (show errors, fail on HTTP errors)Dependency Updates
nitro-codegentonitrogen(package renamed)CI Improvements
.github/actions/setup-buncomposite actionTest Fixes
Buffer.isBuffer()tests (instanceoffails across module boundaries in RN)Example App
react-native-mmkvfor Nitro Modules compatibility testingFixes #882