fix: Make sure isArray passes correctly #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one: ```js const sharedArray = Worklets.createSharedValue([0, 1, 2, 3]); const isArray = Array.isArray(sharedArray.value); // <- returns false ``` Is now working.
To be able to perform tests and verify if an object is a valid jsi::Array and jsi::Object, a couple of "hidden" methods has been added: __jsi_is_array and __jsi_is_object.
A lot of the classes had misleading ctors, like accepting runtime/value parameters without using them. This cleans up this mess.
This will help us decide if we should create a copy or a wrapper when unwrapping later.
Now working so that values created with createSharedValue will return proxies when needed, while wrappers other than this returns a copy of arrays.
Member
|
Is that PR ready? |
Collaborator
Author
|
Yes 👍🏼
|
mrousavy
approved these changes
Apr 9, 2024
Comment on lines
+468
to
+469
| " if (prop === 'length') return " | ||
| "Object.keys(target).length;" |
Member
There was a problem hiding this comment.
Isn't this now changed behaviour? Doesn't .length now include all functions, like .map(), etc as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed proxying so that shared values uses proxies, while all other wrapping doesn't. This solves issues described in #158
Closes #158