Conversation
Signed-off-by: Armand Craig <ajcraig@ra.rockwell.com>
singhmj-1
left a comment
There was a problem hiding this comment.
The default value should be main branch, hence approving. Just one thing on mind, what should we do with these variables when we create release tags? Should be auto-generated via some pipeline or should leave it to the user to configure it?
we can ignore this as I am creating the single env file for device-agent aslo. Device type is identified during script execution with following commands.
sudo -E bash device-agent.sh docker # for docker-compose device
sudo -E bash device-agent.sh k3s # for k3s device
Refer updated setup guide: https://github.com/margo/sandbox/blob/dev-sprint-12/docs/setup-guide.md
this has been handled as part of #163 ( we can use tags also once this PR merged to main). It is better to leave user to configure. |
small update to the docker.env to point to main branch.