Skip to content

Update device-agent_docker.env#162

Merged
vireshnavalli merged 1 commit intomainfrom
fix-branch-reference
Jan 8, 2026
Merged

Update device-agent_docker.env#162
vireshnavalli merged 1 commit intomainfrom
fix-branch-reference

Conversation

@ajcraig
Copy link
Copy Markdown
Collaborator

@ajcraig ajcraig commented Dec 23, 2025

small update to the docker.env to point to main branch.

Signed-off-by: Armand Craig <ajcraig@ra.rockwell.com>
@ajcraig ajcraig added the bug Something isn't working label Dec 23, 2025
Copy link
Copy Markdown
Contributor

@singhmj-1 singhmj-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value should be main branch, hence approving. Just one thing on mind, what should we do with these variables when we create release tags? Should be auto-generated via some pipeline or should leave it to the user to configure it?

vireshnavalli
vireshnavalli previously approved these changes Dec 24, 2025
@vireshnavalli vireshnavalli dismissed their stale review December 26, 2025 11:54

we can ignore this as I am creating the single env file for device-agent aslo. Device type is identified during script execution with following commands.

sudo -E bash device-agent.sh docker # for docker-compose device
sudo -E bash device-agent.sh k3s # for k3s device

Refer updated setup guide: https://github.com/margo/sandbox/blob/dev-sprint-12/docs/setup-guide.md

@vireshnavalli
Copy link
Copy Markdown
Contributor

The default value should be main branch, hence approving. Just one thing on mind, what should we do with these variables when we create release tags? Should be auto-generated via some pipeline or should leave it to the user to configure it?

this has been handled as part of #163 ( we can use tags also once this PR merged to main). It is better to leave user to configure.

@vireshnavalli vireshnavalli merged commit d5f3f59 into main Jan 8, 2026
@vireshnavalli vireshnavalli deleted the fix-branch-reference branch January 23, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants