-
Notifications
You must be signed in to change notification settings - Fork 2
improve code style #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve code style #179
Conversation
2e46073 to
485262d
Compare
Apply following code style: * No trailing whitespaces * Use 2 whitespaces for each indentation level * Use 2 empty newlines to separate functions * Do not put any empty newlines separating function documentation and the function itself * Use only 1 empty newline to create separations inside of functions Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
Add "editorconfig" configuration for YAML, MarkDown, Go and Shell files. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
15dc016 to
d968b67
Compare
|
The tool |
Go has a well-defined code style that gets enforced with "go fmt ./...". This patch applies it to all the Go source code files. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
|
@Silvanoc can you share how to use the tool for this? Note: ( we are planning to include a sanity test automatically triggered via github actions once code is committed to a particular branch) cc @singhmj-1 |
|
Need to have the go tooling as well in the ci/cd and our dev environments. Somehow the old golang code wasn't |
Some of them yes. I'm preparing another PR to provide linting and formatting tools both for local and CI use. |
|
I'm making this PR draft and splitting it. I'm adding tools for formatting and linting for the different programming languages and files and the fixed files. That way you can reproduce yourself how the changes on the existing code are being applied by some tool and not by me manually. |
|
Superseded by #196 |
Apply following code style: