Skip to content

Conversation

@Silvanoc
Copy link
Contributor

Apply following code style:

  • No trailing whitespaces
  • Use 2 whitespaces for each indentation level
  • Use 2 empty newlines to separate functions
  • Do not put any empty newlines separating function documentation and the function itself
  • Use only 1 empty newline to create separations inside of functions

@Silvanoc Silvanoc mentioned this pull request Jan 16, 2026
@Silvanoc Silvanoc force-pushed the improve-code-style branch 3 times, most recently from 2e46073 to 485262d Compare January 16, 2026 15:50
Apply following code style:

* No trailing whitespaces
* Use 2 whitespaces for each indentation level
* Use 2 empty newlines to separate functions
* Do not put any empty newlines separating function documentation
  and the function itself
* Use only 1 empty newline to create separations inside of functions

Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
Add "editorconfig" configuration for YAML, MarkDown, Go and Shell files.

Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
@Silvanoc
Copy link
Contributor Author

The tool editorconfig-checker can be used to see all the non-complying places in the repository. There are lots of them.

Go has a well-defined code style that gets enforced with "go fmt ./...".
This patch applies it to all the Go source code files.

Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
@vireshnavalli
Copy link
Contributor

vireshnavalli commented Jan 27, 2026

@Silvanoc can you share how to use the tool for this?
Also does this validated by deploying sample application as there are many files changed.

Note: ( we are planning to include a sanity test automatically triggered via github actions once code is committed to a particular branch)

cc @singhmj-1

@singhmj-1
Copy link
Contributor

singhmj-1 commented Jan 27, 2026

Need to have the go tooling as well in the ci/cd and our dev environments. Somehow the old golang code wasn't gofmted , and this PR fixes it as well. Thanks!

@Silvanoc
Copy link
Contributor Author

@Silvanoc can you share how to use the tool for this? Also does this validated by deploying sample application as there are many files changed.

Some of them yes. I'm preparing another PR to provide linting and formatting tools both for local and CI use.

@Silvanoc Silvanoc marked this pull request as draft January 27, 2026 14:12
@Silvanoc
Copy link
Contributor Author

I'm making this PR draft and splitting it. I'm adding tools for formatting and linting for the different programming languages and files and the fixed files. That way you can reproduce yourself how the changes on the existing code are being applied by some tool and not by me manually.

@Silvanoc
Copy link
Contributor Author

Superseded by #196

@Silvanoc Silvanoc closed this Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants