Skip to content

fix: cleanup empty file#140

Merged
phil-abb merged 1 commit intopre-draftfrom
cleanup-empty-file
Mar 17, 2026
Merged

fix: cleanup empty file#140
phil-abb merged 1 commit intopre-draftfrom
cleanup-empty-file

Conversation

@Silvanoc
Copy link
Copy Markdown
Contributor

@Silvanoc Silvanoc commented Mar 6, 2026

Description

Remove an empty useless file

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Fix (change that resolves an issue)
  • New enhancement (change that adds specification content)
  • Content edits (change that edits existing content)

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established patterns, and best practices.

Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
@Silvanoc Silvanoc requested a review from a team as a code owner March 6, 2026 15:28
@phil-abb
Copy link
Copy Markdown
Contributor

It's been two weeks, and there are no additional comments. Since it's just removing a file, I'm going to bypass the rules and merge

cc @ajcraig

@phil-abb phil-abb merged commit 8874979 into pre-draft Mar 17, 2026
8 of 10 checks passed
@phil-abb
Copy link
Copy Markdown
Contributor

@Silvanoc / @arne-broering

After merging this PR, the build started to fail: https://github.com/margo/specification/actions/runs/23191064274

If I add this empty file back and run the generate-documentation.bash script locally, it works fine. I made an update to the application-description.linkml.yaml file in this branch, and with that change, the script works, but the validations started failing.

Can you guys take a look at it?

cc @ajcraig

@Silvanoc
Copy link
Copy Markdown
Contributor Author

@Silvanoc / @arne-broering

After merging this PR, the build started to fail: https://github.com/margo/specification/actions/runs/23191064274

If I add this empty file back and run the generate-documentation.bash script locally, it works fine. I made an update to the application-description.linkml.yaml file in this branch, and with that change, the script works, but the validations started failing.

Can you guys take a look at it?

cc @ajcraig

Damn it! I oversaw that LinkML needs it! 🫣 Sorry, my bad. Reverting my change should fix it. And I'll check with time if it's possible to convince LinkML that such an empty file is not needed.

@Silvanoc
Copy link
Copy Markdown
Contributor Author

@phil-abb @ajcraig PR #165 should fix this issue reverting my previous erroneous PR. Sorry for the inconvenience.

@Silvanoc Silvanoc deleted the cleanup-empty-file branch March 17, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants