Backup & Restore: support for SSE-C #1520
Merged
+751
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierleune
changed the title
Member
|
Thanks for this contribution @xavierleune, we are willing to support this. I'm on holiday currently, but @Michaelpalacce might be able to do an initial review |
xavierleune
force-pushed
the
feature/backup-ssec
branch
from
102d8cf to
a18adf3
Compare
Contributor
Author
|
Thanks @mmontes11, enjoy your holiday ! |
mmontes11
force-pushed
the
feature/backup-ssec
branch
from
a18adf3 to
946a704
Compare
mmontes11
requested changes
Dec 1, 2025
Member
mmontes11
left a comment
mmontes11
left a comment
There was a problem hiding this comment.
Left some comments after an initial review. This still needs to be validated with our development Minio installation.
mmontes11
requested changes
Dec 1, 2025
Member
mmontes11
left a comment
mmontes11
left a comment
There was a problem hiding this comment.
Managed to validate this in our local MinIO installation. Left some additional comments
mmontes11
approved these changes
Dec 2, 2025
Member
mmontes11
left a comment
mmontes11
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this contribution @xavierleune ! I'll make the adaptations of the docs myself
Merged
Contributor
Author
|
Thanks @mmontes11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds support for SSE-C, thanks to minio-go that already supports it.
Fixes #1084