chore: pin pnpm via packageManager#123
Merged
Merged
Conversation
Adds packageManager: pnpm@10.28.2 to package.json and drops the redundant `version:` arg from pnpm/action-setup. The action now reads the version from packageManager, giving a single source of truth shared between local dev and CI.
There was a problem hiding this comment.
Pull request overview
Pins the project’s pnpm version via package.json’s packageManager field and simplifies GitHub Actions workflows to rely on that single source of truth, aligning local development and CI.
Changes:
- Add
"packageManager": "pnpm@10.28.2"topackage.json. - Remove the redundant
with: version: 10configuration frompnpm/action-setupin CI/release/demo workflows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Declares the pinned pnpm version via packageManager. |
| .github/workflows/test.yml | Drops explicit pnpm version so CI reads from packageManager. |
| .github/workflows/release.yml | Drops explicit pnpm version so release workflow reads from packageManager. |
| .github/workflows/demo.yml | Drops explicit pnpm version so demo workflow reads from packageManager. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
"packageManager": "pnpm@10.28.2"topackage.jsonand drops the redundantversion:arg frompnpm/action-setupin CI.The action now reads the version from
packageManager, giving a single source of truth shared between local dev and CI. Matches the convention used inmarimoandmarimo-lsp.