refactor(fp): v0.1.1 of notebook 05_functors.py#68
Conversation
Contributor
|
Unchecked the package dependencies and README boxes from the above desc as it was already included in the previous PR when you added the notebook. The checklist should be specific to a PR's changes. |
Haleshot
approved these changes
Mar 17, 2025
Contributor
Haleshot
left a comment
There was a problem hiding this comment.
Great; just went through the changes 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Use uppercased letters for
Generictypes, e.g.A = TypeVar("A")Refactor the
Functorclass, changingfmapand utility methods toclassmethodFor example:
Move the
check_functor_lawmethod fromFunctorclass to a standard functionListWrappertoListfor simplicityJustclass📋 Checklist
--sandboxREADME.md