Exclude index columns for pivot for count/sum agg#8769
Merged
Light2Dark merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a pivot transform edge case where fill_null(0) was being applied to pivot index columns, which could cast boolean index columns to integers (or error) in some Polars versions. The handler now fills nulls only for the aggregated value columns, and adds a regression test to prevent dtype regressions.
Changes:
- Update
handle_pivotto applyfill_null(0)only to non-index (aggregated) columns forcount/sum. - Add a Polars regression test ensuring boolean index column dtypes are preserved for
countpivots.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
marimo/_plugins/ui/_impl/dataframes/transforms/handlers.py |
Excludes pivot index columns from fill_null(0) to avoid dtype casting/errors. |
tests/_plugins/ui/_impl/dataframes/test_handlers.py |
Adds a regression test asserting boolean index dtype is preserved after a count pivot. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mscolnick
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This was caught in CI tests.
Fix pivot fill_null(0) casting boolean index columns
handle_pivot applied nw.all().fill_null(0) to every column — including index columns. On boolean index columns this either silently casts the dtype to Int32 or raises an InvalidOperationError depending on the Polars version. Use nw.exclude(*index_columns).fill_null(0) so only the aggregated value columns are filled.
Adds a regression test in test_handlers.py.
🔍 Description of Changes
📋 Checklist