Skip to content

improvement: add data-testids to file-explorer dropdown menu items#9427

Merged
mscolnick merged 1 commit intomainfrom
ms/file-explorer-data-ids
Apr 30, 2026
Merged

improvement: add data-testids to file-explorer dropdown menu items#9427
mscolnick merged 1 commit intomainfrom
ms/file-explorer-data-ids

Conversation

@mscolnick
Copy link
Copy Markdown
Contributor

@mscolnick mscolnick commented Apr 30, 2026

Add data-test IDs to menu items

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Apr 30, 2026 5:37am

Request Review

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Architecture diagram
sequenceDiagram
    participant Test as Test Suite (Playwright/Cypress)
    participant Explorer as File Explorer Component
    participant Ops as File Operations (Sub-components)
    participant DOM as Browser DOM
    participant App as App State / Backend

    Note over Test, DOM: UI Selection & Action Flow

    Explorer->>Ops: NEW: Pass testId to Rename/Duplicate/Delete
    Ops->>DOM: NEW: Render DropdownMenuItem with [data-testid]
    Explorer->>DOM: NEW: Render file/folder items with [data-testid]

    Test->>DOM: NEW: Locate element via [data-testid]
    Test->>DOM: Perform click/select action

    alt File Action
        DOM->>Explorer: onSelect() triggered
        Explorer->>App: handleCreateNotebook() / handleCreateFile()
    else File Operation (Rename/Delete)
        DOM->>Ops: onSelect() triggered
        Ops->>Explorer: Callback executed
        Explorer->>App: handleDeleteFile() / handleDuplicate()
    end

    App-->>Explorer: Update file tree
    Explorer-->>DOM: Re-render updated state
Loading

@mscolnick mscolnick added internal A refactor or improvement that is not user facing enhancement New feature or request and removed internal A refactor or improvement that is not user facing labels Apr 30, 2026
@mscolnick mscolnick changed the title test: add data-testids to file-explorer dropdown menu items improvement: add data-testids to file-explorer dropdown menu items Apr 30, 2026
@mscolnick mscolnick requested a review from Light2Dark April 30, 2026 05:43
@mscolnick mscolnick enabled auto-merge (squash) April 30, 2026 05:43
@mscolnick mscolnick merged commit 76509ce into main Apr 30, 2026
41 of 42 checks passed
@mscolnick mscolnick deleted the ms/file-explorer-data-ids branch April 30, 2026 06:21
@github-actions
Copy link
Copy Markdown

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.5-dev7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants