feat(ui): support disabled on dropdown and multiselect#9600
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
1 issue found across 8 files
Architecture diagram
sequenceDiagram
participant User as User (Browser)
participant UI as UI Component (dropdown/multiselect)
participant Combobox as Combobox (Searchable, Multiselect)
participant Plugin as Frontend Plugin
participant Backend as Python Backend
Note over User,Backend: Dropdown / Multiselect disabled state flow
User->>UI: Interact with dropdown/multiselect
alt Native select path (searchable=false)
UI->>UI: CHECK: disabled attribute on <select>
alt Disabled
UI-->>User: Native browser disabled styling and behavior
end
else Combobox path (searchable=true or multiselect)
User->>Combobox: Click trigger / close chip
Combobox->>Combobox: CHECK: disabled prop
alt Disabled
Combobox->>Combobox: Block popover open via onOpenChange guard
Combobox->>Combobox: Block chip removal via onClick guard
Combobox-->>User: aria-disabled="true" + pointer-events-none + opacity-50
end
end
Note over Plugin,Backend: Data flow from Python to frontend
Backend->>Plugin: Render request with component args (disabled=bool)
Plugin->>Plugin: Destructure disabled from data props
Plugin->>UI: Pass disabled={disabled}
UI->>Combobox: Pass disabled={disabled} (if searchable/multiselect)
Note over UI: Disabled value defaults to false
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
mscolnick
previously approved these changes
May 19, 2026
Light2Dark
reviewed
May 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds disabled-state support for dropdown and multiselect UI elements across Python component args and frontend rendering.
Changes:
- Adds
disabledkwargs tomo.ui.dropdownandmo.ui.multiselect. - Plumbs disabled state through dropdown, searchable select, multiselect, and shared combobox UI.
- Adds Python and dropdown frontend tests for disabled behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
marimo/_plugins/ui/_impl/input.py |
Adds disabled component args and docs for dropdown/multiselect. |
tests/_plugins/ui/_impl/test_input.py |
Verifies disabled defaults and explicit true values. |
frontend/src/plugins/impl/DropdownPlugin.tsx |
Adds disabled schema support and native select propagation. |
frontend/src/plugins/impl/SearchableSelect.tsx |
Passes disabled state into shared combobox. |
frontend/src/plugins/impl/MultiselectPlugin.tsx |
Adds disabled schema support and combobox propagation. |
frontend/src/components/ui/combobox.tsx |
Adds disabled styling and interaction blocking for combobox. |
frontend/src/plugins/impl/__tests__/DropdownPlugin.test.tsx |
Adds frontend disabled dropdown coverage. |
frontend/src/components/data-table/charts/components/form-fields.tsx |
Updates internal multiselect usage for required disabled prop. |
Adds a disabled kwarg to mo.ui.dropdown and mo.ui.multiselect, matching the pattern used by other inputs. The Combobox-based searchable dropdown and multiselect block popover toggling and chip removal via aria-disabled and pointer styling; the native select uses the native disabled attribute.
2ba8893 to
1e5a9e1
Compare
Light2Dark
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disabledkwarg tomo.ui.dropdownandmo.ui.multiselect, matching the pattern already used by other inputs (text,slider,checkbox,radio,button, etc.).<select>path uses the nativedisabledattribute.aria-disabledand pointer-events styling; the trigger remains a<div>to avoid changing focus/keyboard semantics for existing combobox usages.Closes #9579
Screen.Recording.2026-05-18.at.8.58.46.PM.mov
Test plan
make checktest_dropdown_disabled,test_multiselect_disabled