fix: jump to running notebook cells only#9707
Merged
Merged
Conversation
When code-mode execution adds runtime-only running entries, the jump-to-running-cell action could select an id with no notebook DOM node and fail to scroll. Select running cells from notebook order instead, and add a regression test covering a runtime-only running entry before a visible running notebook cell. Closes marimo-team#9706
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the “Jump to running cell” behavior by ensuring the jump target is chosen from the notebook’s ordered cell list (DOM-backed cells) rather than from runtime state entries that may include runtime-only IDs.
Changes:
- Update
notebookScrollToRunning()to select the first"running"cell fromcellIds.inOrderIdsinstead of iterating overcellRuntimeentries. - Add a regression test covering the scenario where a runtime-only running entry exists before a visible running notebook cell.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/core/cells/actions.ts | Selects the running cell by notebook order to avoid runtime-only IDs with no DOM node. |
| frontend/src/core/cells/tests/actions.test.ts | Adds a regression test ensuring the action scrolls to the visible running cell even when runtime-only running state exists. |
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.9-dev19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
When code-mode execution adds runtime-only running entries, the jump-to-running-cell action could select an id with no notebook DOM node and fail to scroll.
Select running cells from notebook order instead, and add a regression test covering a runtime-only running entry before a visible running notebook cell.
Closes #9706
jump-to-running-cell-wide.mp4
📋 Pre-Review Checklist
✅ Merge Checklist