Skip to content

fix: jump to running notebook cells only#9707

Merged
Light2Dark merged 1 commit into
marimo-team:mainfrom
kjgoodrick:fix/running-cell-jump
May 29, 2026
Merged

fix: jump to running notebook cells only#9707
Light2Dark merged 1 commit into
marimo-team:mainfrom
kjgoodrick:fix/running-cell-jump

Conversation

@kjgoodrick
Copy link
Copy Markdown
Contributor

📝 Summary

When code-mode execution adds runtime-only running entries, the jump-to-running-cell action could select an id with no notebook DOM node and fail to scroll.

Select running cells from notebook order instead, and add a regression test covering a runtime-only running entry before a visible running notebook cell.

Closes #9706

jump-to-running-cell-wide.mp4

📋 Pre-Review Checklist

  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
  • Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

  • I have read the contributor guidelines.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Tests have been added for the changes made.

When code-mode execution adds runtime-only running entries, the jump-to-running-cell action could select an id with no notebook DOM node and fail to scroll.

Select running cells from notebook order instead, and add a regression test covering a runtime-only running entry before a visible running notebook cell.

Closes marimo-team#9706
@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment May 28, 2026 2:11am

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the “Jump to running cell” behavior by ensuring the jump target is chosen from the notebook’s ordered cell list (DOM-backed cells) rather than from runtime state entries that may include runtime-only IDs.

Changes:

  • Update notebookScrollToRunning() to select the first "running" cell from cellIds.inOrderIds instead of iterating over cellRuntime entries.
  • Add a regression test covering the scenario where a runtime-only running entry exists before a visible running notebook cell.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
frontend/src/core/cells/actions.ts Selects the running cell by notebook order to avoid runtime-only IDs with no DOM node.
frontend/src/core/cells/tests/actions.test.ts Adds a regression test ensuring the action scrolls to the visible running cell even when runtime-only running state exists.

@dmadisetti dmadisetti requested a review from Light2Dark May 28, 2026 16:39
Copy link
Copy Markdown
Collaborator

@Light2Dark Light2Dark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Light2Dark Light2Dark merged commit c84817a into marimo-team:main May 29, 2026
26 of 28 checks passed
@github-actions
Copy link
Copy Markdown

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.9-dev19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: "Jump to running cell" does not jump for Marimo Pair/code-mode runs

4 participants