Skip to content

slides: add cells with no output to the minimap & viewer#9771

Merged
Light2Dark merged 1 commit into
mainfrom
sham/include-no-output-cells
Jun 3, 2026
Merged

slides: add cells with no output to the minimap & viewer#9771
Light2Dark merged 1 commit into
mainfrom
sham/include-no-output-cells

Conversation

@Light2Dark
Copy link
Copy Markdown
Collaborator

@Light2Dark Light2Dark commented Jun 3, 2026

📝 Summary

Because we allow code-edits for slides, there is a chance the slide may be edited to no longer produce an output, in which case it disappears. This adds a handling where we display all cells, and you can edit it to add to the deck.

Note that in a presentation, cells with no output are still skipped/hidden.

Screen.Recording.2026-06-03.at.2.25.46.PM.mov

I've also made the thumbnails in the minimap bigger and more readable.

📋 Pre-Review Checklist

  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it.
  • Video or media evidence is provided for any visual changes (optional).

✅ Merge Checklist

  • I have read the contributor guidelines.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Tests have been added for the changes made.

Copilot AI review requested due to automatic review settings June 3, 2026 06:28
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Jun 3, 2026 6:28am

Request Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the slides authoring experience so cells that no longer render output (e.g., after code edits) still appear in the slides minimap and can be selected/edited, while remaining hidden/skipped during actual presentations.

Changes:

  • Keep all cells in the slides “minimap order” list and track noOutputIds so output-less cells can be shown in the minimap/editor UI.
  • Treat no-output cells as effectively skipped for reveal.js composition, and add a parked-preview overlay message/behavior when selected.
  • Add a minimap thumbnail fallback for no-output cells that shows a small code preview.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
frontend/src/components/slides/reveal-component.tsx Adds “parked preview” handling for selected no-output cells and ensures reveal composition skips them.
frontend/src/components/slides/minimap.tsx Adds noOutputIds support and renders code thumbnails for no-output cells in the minimap.
frontend/src/components/editor/renderers/slides-layout/slides-layout.tsx Wires slideCells/noOutputIds through the slides layout renderer to the minimap and deck viewer.
frontend/src/components/editor/renderers/slides-layout/compute-slide-cells.ts Stops filtering out no-output cells; computes noOutputIds and treats them as effectively skipped.
frontend/src/components/editor/renderers/slides-layout/tests/compute-slide-cells.test.ts Updates/extends tests to cover slideCells, noOutputIds, and starting-cell selection behavior.

Comment thread frontend/src/components/slides/minimap.tsx
Comment thread frontend/src/components/slides/minimap.tsx
@Light2Dark Light2Dark added the enhancement New feature or request label Jun 3, 2026
@Light2Dark Light2Dark requested a review from dmadisetti June 3, 2026 07:34
@Light2Dark Light2Dark merged commit d0352e2 into main Jun 3, 2026
36 of 38 checks passed
@Light2Dark Light2Dark deleted the sham/include-no-output-cells branch June 3, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants