slides: add cells with no output to the minimap & viewer#9771
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the slides authoring experience so cells that no longer render output (e.g., after code edits) still appear in the slides minimap and can be selected/edited, while remaining hidden/skipped during actual presentations.
Changes:
- Keep all cells in the slides “minimap order” list and track
noOutputIdsso output-less cells can be shown in the minimap/editor UI. - Treat no-output cells as effectively skipped for reveal.js composition, and add a parked-preview overlay message/behavior when selected.
- Add a minimap thumbnail fallback for no-output cells that shows a small code preview.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/components/slides/reveal-component.tsx | Adds “parked preview” handling for selected no-output cells and ensures reveal composition skips them. |
| frontend/src/components/slides/minimap.tsx | Adds noOutputIds support and renders code thumbnails for no-output cells in the minimap. |
| frontend/src/components/editor/renderers/slides-layout/slides-layout.tsx | Wires slideCells/noOutputIds through the slides layout renderer to the minimap and deck viewer. |
| frontend/src/components/editor/renderers/slides-layout/compute-slide-cells.ts | Stops filtering out no-output cells; computes noOutputIds and treats them as effectively skipped. |
| frontend/src/components/editor/renderers/slides-layout/tests/compute-slide-cells.test.ts | Updates/extends tests to cover slideCells, noOutputIds, and starting-cell selection behavior. |
mscolnick
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Because we allow code-edits for slides, there is a chance the slide may be edited to no longer produce an output, in which case it disappears. This adds a handling where we display all cells, and you can edit it to add to the deck.
Note that in a presentation, cells with no output are still skipped/hidden.
Screen.Recording.2026-06-03.at.2.25.46.PM.mov
I've also made the thumbnails in the minimap bigger and more readable.
📋 Pre-Review Checklist
✅ Merge Checklist