Update menu.rs#1
Merged
Merged
Conversation
Byron
reviewed
Feb 17, 2025
Byron
suggested changes
Feb 17, 2025
There was a problem hiding this comment.
Thanks a lot for sorting this out!
It's true that the menu bar, static as it is for now, should be general in the light of changed editor settings.
Could you make it uppercase? Then it's ready to go.
Thanks again.
Edit: And it would be desirable to open this PR on GitButler repository.
Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gitbutlerapp#7318
🧢 Changes
Fixes hardcoded dropdown menu button to more reasonable, since gitbutler can work with multiple editors
☕️ Reasoning
Correct semantics of the button
🎫 Affected issues
Fixes: gitbutlerapp#7318