simplify required field handling in inputSchema

[yikakia]

append will handle nil slice. do not have to use if

Summary by CodeRabbit

• Refactor
  • Simplified the underlying logic for registering required properties in tool configurations, reducing redundancy and streamlining the process.

[coderabbitai]

Walkthrough

The pull request modifies the logic in mcp/tools.go that manages the addition of required property names to a tool’s InputSchema. The update eliminates the conditional nil-check previously used to initialize the Required slice, replacing it with a direct append operation across multiple functions: WithBoolean, WithNumber, WithString, WithObject, and WithArray.

Changes

File	Summary
mcp/tools.go	Removed the conditional check for a nil Required slice and replaced it with a direct append of the property name across functions (WithBoolean, WithNumber, WithString, WithObject, WithArray).

Possibly related PRs

• tools: add WithObject and WithArray to supplement type definition utility #47: Introduces new functions (WithObject and WithArray) that modify the InputSchema.Required list in a similar way, directly relating to the changes in this PR.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3dc35c and bc2b451.

📒 Files selected for processing (1)

• mcp/tools.go (5 hunks)

🔇 Additional comments (5)

mcp/tools.go (5)

308-308: Approved: Simpler required field handling

This change leverages Go's built-in behavior where append automatically handles nil slices by creating a new slice. This is more idiomatic and removes the need for a conditional nil check.

---

330-330: Approved: Consistent implementation across property types

The same simplified approach is correctly applied to the WithNumber function, maintaining consistency with the other property type handlers.

---

352-352: Approved: Clean implementation for string properties

The simplified required field handling is properly implemented for string properties, following the same pattern as other property types.

---

375-375: Approved: Proper handling for object properties

The object property handler correctly implements the simplified required field approach, consistent with the other property types.

---

397-397: Approved: Simplified array property required handling

The array property implementation follows the same simplified pattern, completing the consistent implementation across all property types.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.