chore: self-bootstrap validation and release automation#2
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
2 issues found across 56 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/site/src/routes/embed/$memoId.tsx">
<violation number="1" location="apps/site/src/routes/embed/$memoId.tsx:112">
P2: Removing `html` from this effect dependency breaks resize updates for the no-`ResizeObserver` fallback path when embed content changes.</violation>
</file>
<file name=".github/workflows/publish.yml">
<violation number="1" location=".github/workflows/publish.yml:38">
P2: Pin the new third-party action to a full commit SHA instead of a mutable tag to reduce supply-chain risk in the publish workflow.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| container: containerRef.current, | ||
| }); | ||
| }, [frameId, html]); | ||
| }, [frameId]); |
There was a problem hiding this comment.
P2: Removing html from this effect dependency breaks resize updates for the no-ResizeObserver fallback path when embed content changes.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/site/src/routes/embed/$memoId.tsx, line 112:
<comment>Removing `html` from this effect dependency breaks resize updates for the no-`ResizeObserver` fallback path when embed content changes.</comment>
<file context>
@@ -109,7 +109,7 @@ export function EmbedPreview({
container: containerRef.current,
});
- }, [frameId, html]);
+ }, [frameId]);
return <div ref={containerRef} />;
</file context>
Suggested change
| }, [frameId]); | |
| }, [frameId, html]); |
|
|
||
| - run: npx changelogithub | ||
| - name: Create release PR or publish packages | ||
| uses: changesets/action@v1 |
There was a problem hiding this comment.
P2: Pin the new third-party action to a full commit SHA instead of a mutable tag to reduce supply-chain risk in the publish workflow.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/publish.yml, line 38:
<comment>Pin the new third-party action to a full commit SHA instead of a mutable tag to reduce supply-chain risk in the publish workflow.</comment>
<file context>
@@ -24,18 +25,23 @@ jobs:
-
- - run: npx changelogithub
+ - name: Create release PR or publish packages
+ uses: changesets/action@v1
+ with:
+ version: pnpm version-packages
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm validateflow and wire lint/check into CITesting
Summary by cubic
Adds a repo-wide pnpm validate and switches publishing to a Changesets release-PR flow to automate releases and improve quality. Also adds site smoke tests, tarball consumer tests, Vitest workspace-source aliases, and Paraglide test mocks for more stable runs.
New Features
Migration
Written for commit 285f5eb. Summary will update on new commits.