feat: improve embed wrapper ergonomics#5
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
1 issue found across 29 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/memos-embed/src/__tests__/theme.test.ts">
<violation number="1" location="packages/memos-embed/src/__tests__/theme.test.ts:6">
P2: This test case does not match its stated behavior: it checks omitted input, not an unknown theme name, leaving the unknown-string fallback path untested.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| describe("resolveTheme", () => { | ||
| it("falls back to the default theme for unknown input", () => { | ||
| expect(resolveTheme()).toEqual(themePresets.minimal); |
There was a problem hiding this comment.
P2: This test case does not match its stated behavior: it checks omitted input, not an unknown theme name, leaving the unknown-string fallback path untested.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/memos-embed/src/__tests__/theme.test.ts, line 6:
<comment>This test case does not match its stated behavior: it checks omitted input, not an unknown theme name, leaving the unknown-string fallback path untested.</comment>
<file context>
@@ -0,0 +1,50 @@
+
+describe("resolveTheme", () => {
+ it("falls back to the default theme for unknown input", () => {
+ expect(resolveTheme()).toEqual(themePresets.minimal);
+ });
+});
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extendTheme(), optional built-in style disabling, and Web Component::part(...)guidancefetchMemos()andrenderMemoListHtmlSnippet()for roundups, weekly notes, and archive pagesMemoEmbedListto the React package so React/MDX blogs can render multiple memo cards with one shared style blockcreateMemoClient()in core plusMemoClientProviderin React for cross-embed request deduping on pages with many embedsTesting