feat: add shared memo client for react embeds

[markbang]

Summary

• add createMemoClient() in core for cross-embed memo and creator request deduping
• add MemoClientProvider and useMemoClient() in @memos-embed/react, wiring both MemoEmbed and MemoEmbedList into shared client usage
• document the shared-client workflow across README, package docs, and site docs, and keep pack-smoke coverage aligned

Testing

• pnpm validate

---

Summary by cubic

Adds a shared memo client to memos-embed with a React provider/hook so multiple embeds reuse memo/creator requests and avoid duplicate fetches. Docs and tests were updated to cover the new workflow.

• New Features
  • memos-embed: createMemoClient() with in-memory caching, fetchMemo/fetchMemos, primeMemo/primeMemos, and clear().
  • @memos-embed/react: MemoClientProvider and useMemoClient(); MemoEmbed and MemoEmbedList accept an optional client prop and use the shared client when available (prefetched data is primed into the client; without a client, existing per-component fetch/abort behavior remains).
  • Docs updated with “Shared React memo client” examples; tests and pack-smoke scripts validate new exports and provider flow.

^{Written for commit 3793df7. Summary will update on new commits.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
memos-embed-site	Ready	Preview, Comment	Mar 9, 2026 9:12am

[cubic-dev-ai]

3 issues found across 13 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/memos-embed-react/src/index.tsx">

<violation number="1" location="packages/memos-embed-react/src/index.tsx:109">
P1: `useContext` is called conditionally in `useMemoClient`, which can break hook ordering across renders.</violation>
</file>

<file name="packages/memos-embed/src/api.ts">

<violation number="1" location="packages/memos-embed/src/api.ts:158">
P1: Shared user caching is keyed only by user ID, so one `createMemoClient` used across multiple `baseUrl` values can return creator data from the wrong instance.</violation>

<violation number="2" location="packages/memos-embed/src/api.ts:315">
P2: `createMemoClient().fetchMemo` drops the `signal` option, so abort/cancellation passed by callers is silently ignored.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P1: useContext is called conditionally in useMemoClient, which can break hook ordering across renders.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/memos-embed-react/src/index.tsx, line 109:

<comment>`useContext` is called conditionally in `useMemoClient`, which can break hook ordering across renders.</comment>

<file context>
@@ -86,6 +91,23 @@ export type MemoEmbedListProps =
+);
+
+export const useMemoClient = (client?: MemoClient) =>
+	client ?? useContext(MemoClientContext);
+
 const renderState = ({
</file context>

[cubic-dev-ai]

P1: Shared user caching is keyed only by user ID, so one createMemoClient used across multiple baseUrl values can return creator data from the wrong instance.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/memos-embed/src/api.ts, line 158:

<comment>Shared user caching is keyed only by user ID, so one `createMemoClient` used across multiple `baseUrl` values can return creator data from the wrong instance.</comment>

<file context>
@@ -114,37 +133,38 @@ const normalizeMemo = (
+	const normalizedBaseUrl = normalizeBaseUrl(baseUrl);
 	const id = userId.includes("/") ? getIdFromName(userId) : userId;
-	const cached = context.userCache.get(id);
+	const cached = userCache.get(id);
 	if (cached) {
 		return cached;
</file context>

[cubic-dev-ai]

P2: createMemoClient().fetchMemo drops the signal option, so abort/cancellation passed by callers is silently ignored.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/memos-embed/src/api.ts, line 315:

<comment>`createMemoClient().fetchMemo` drops the `signal` option, so abort/cancellation passed by callers is silently ignored.</comment>

<file context>
@@ -191,33 +225,144 @@ const fetchMemoWithContext = async ({
+	const memoCache: MemoCache = new Map();
+	const userCache: UserCache = new Map();
+
+	const clientFetchMemo: MemoClient["fetchMemo"] = async ({
+		baseUrl,
+		memoId,
</file context>

Suggested change

	const clientFetchMemo: MemoClient["fetchMemo"] = async ({
	baseUrl,
	memoId,
	includeCreator = true,
	fetcher,
	}) =>
	fetchMemoWithCache({
	baseUrl,
	memoId,
	includeCreator,
	fetcher: fetcher ?? config.fetcher ?? fetch,
	userCache,
	memoCache,
	});
	const clientFetchMemo: MemoClient["fetchMemo"] = async ({
	baseUrl,
	memoId,
	includeCreator = true,
	fetcher,
	signal,
	}) =>
	fetchMemoWithCache({
	baseUrl,
	memoId,
	includeCreator,
	fetcher: fetcher ?? config.fetcher ?? fetch,
	signal,
	userCache,
	memoCache,
	});