Fixes for extra profile directories#39
Merged
markfinal merged 2 commits intomarkfinal:v1.3from Dec 12, 2022
Merged
Conversation
Contributor
foundry-markf
commented
Dec 12, 2022
foundry-markf
commented
- debug only messages when the commands were disabled due to an exception
- determining the extra profile directory names was incorrect, causing an exception
…hat otherwise result in no commands being available - previous behaviour was silent unless in LOGLEVEL=DEBUG mode, so no information was given to the user as to why the UI couldn't be used
…a flawed algorithm
foundry-markf
force-pushed
the
mf/extra_profile_dirs_windows_paths
branch
from
ee72b65 to
135e8ba
Compare
markfinal
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.