Skip to content

Issue builder commits on main are not reviewed #2

@markgar

Description

@markgar

Problem

The dedicated issue builder (builder-N with --role issue) works directly on main, but no reviewer watches its commits:

  • Branch-attached reviewers only watch builder-N/* feature branches — the issue builder doesn't use a feature branch.
  • No reviewer is spawned for the issue builder — the orchestrator explicitly skips it (milestone_builder_count = num_builders - 1).
  • Milestone reviewer only triggers on completed milestones, not arbitrary main commits.

This means the issue builder's fix commits go in unreviewed.

Options

  1. Have the issue builder work on its own branch with a dedicated reviewer
  2. Have an existing reviewer also watch non-builder commits on main
  3. Accept the gap — fixes are for already-reviewed/filed issues, so they're implicitly review-driven

Context

Discovered while monitoring a 4-builder Stretto run (3 milestone builders + 1 issue builder). The issue builder picked up 3 findings from reviewer-1 and fixed them directly on main with no review.

Relevant code: src/agentic_dev/orchestrator.py lines 258-261

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions