feat(navigation): align stories and structure#13
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aligns the navigation and breadcrumb-navigation components with the project's current coding standards and improves their Storybook stories structure. The changes primarily focus on code formatting, modernizing imports, migrating from react-popper to @floating-ui/react, and enhancing story interactivity.
Key changes:
- Migration from
react-popperto@floating-ui/reactfor popover positioning - Standardization of code style (single quotes, no semicolons, experimental ternaries) to match prettier configuration
- Modernization of imports (type imports, direct React type imports instead of React namespace)
- Addition of test files for Navigation and BreadcrumbNavigation components
- Refactoring of stories to use args/argTypes pattern for better interactivity
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/navigation/navigation.tsx | Updated imports and formatting to match project standards |
| src/components/navigation/navigation.test.tsx | Added new test file covering basic navigation functionality |
| src/components/navigation/navigation.stories.tsx | Refactored story to use args/argTypes pattern with interactive controls |
| src/components/navigation/navigation-popover.tsx | Migrated from react-popper to @floating-ui/react, updated imports and formatting |
| src/components/navigation/navigation-popover-panel.tsx | Updated to use floating-ui refs and removed attributes prop, aligned formatting |
| src/components/navigation/navigation-popover-overlay.tsx | Simplified imports and updated formatting |
| src/components/navigation/navigation-popover-context.tsx | Updated context types for floating-ui API, aligned formatting |
| src/components/navigation/navigation-popover-button.tsx | Updated ref callback for floating-ui, aligned formatting |
| src/components/navigation/navigation-group.tsx | Updated imports and applied experimental ternary formatting |
| src/components/navigation/navigation-group-item-tag.tsx | Modernized imports and aligned formatting |
| src/components/navigation/navigation-disclosure.tsx | Updated imports and applied experimental ternary formatting |
| src/components/navigation/navigation-disclosure-panel.tsx | Modernized imports and aligned formatting |
| src/components/navigation/index.ts | Updated quote style to match project standards |
| src/components/breadcrumb-navigation/index.tsx | Updated quote style to match project standards |
| src/components/breadcrumb-navigation/breadcrumb-navigation.tsx | Modernized imports and aligned formatting |
| src/components/breadcrumb-navigation/breadcrumb-navigation.test.tsx | Added new test file covering basic breadcrumb functionality |
| src/components/breadcrumb-navigation/breadcrumb-navigation.stories.tsx | Updated imports and aligned formatting with project standards |
| src/components/breadcrumb-navigation/breadcrumb-navigation-item.tsx | Modernized imports and aligned formatting |
| src/components/breadcrumb-navigation/breadcrumb-navigation-arrow.tsx | Simplified imports and updated formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
feat(navigation): align stories and structure
Changes