Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Jan 23, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 23, 2026 18:13
@github-actions
Copy link

github-actions bot commented Jan 23, 2026

Copyright Validation Results
Total: 5 | Passed: 0 | Failed: 0 | Skipped: 5 | at: 2026-01-23 18:18:58 UTC | commit: 4fd0add

⏭️ Skipped (Excluded) Files

  • .copyrightconfig
  • docs/api.md
  • docs/import/embedder/custom-integration.md
  • docs/index.md
  • flux-custom-splitter-example/README.md

✅ All files have valid copyright headers!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Java version references in documentation to reflect current system requirements, replacing Java 11 with Java 17 and Java 21.

Changes:

  • Updated system requirements to specify Java 17 or Java 21 as supported versions
  • Removed outdated note about Java 21 testing status
  • Updated developer prerequisites to require Java 17 or Java 21

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
flux-custom-splitter-example/README.md Updated Java version requirement from "11 or higher" to "17 or Java 21"
docs/index.md Updated system requirements and removed outdated Java 21 testing note
docs/import/embedder/custom-integration.md Updated developer prerequisite from "Java 11 or higher" to "Java 17 or Java 21"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


If you would like to download the Enron email dataset from the above link and test it with this custom splitter,
perform the following steps, using Java 11 or higher:
perform the following steps, using Java 17 or Java 21:
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing 'using Java 17 or Java 21' creates an inconsistency with the other documentation files which use 'Java 17 or higher'. Consider whether this should be 'Java 17 or higher' to allow for future Java versions, or if the restriction to only Java 17 and 21 is intentional and should be consistently documented.

Suggested change
perform the following steps, using Java 17 or Java 21:
perform the following steps, using Java 17 or higher:

Copilot uses AI. Check for mistakes.
@rjrudin rjrudin force-pushed the feature/java11-note branch from 9718a74 to b2d3190 Compare January 23, 2026 18:16
@rjrudin rjrudin force-pushed the feature/java11-note branch from b2d3190 to 4fd0add Compare January 23, 2026 18:18
@rjrudin rjrudin merged commit 0e94199 into main Jan 23, 2026
3 of 4 checks passed
@rjrudin rjrudin deleted the feature/java11-note branch January 23, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants