StructuredQueryBuilder.locks should generate locks-fragment-query

[kcoleman-marklogic]

I think this is currently generating a structured query with a locks-query element, but this has changed to locks-fragment-query in 8.0.

I don't have a test case for you because I came across it via visual inspection when trying to compare what Java does to what Node.js is doing. (Both are wrong, I think). I'm basing this on the serialization I see underneath in StructuredQueryBuilder.locks, but I'm on shaky ground as I don't know diddly about the Java impl.

The other reason is I don't know how to construct a meaningful locks query example. :)

This is not high priority issue. My understanding is this is a relatively obscure query type.

There is a little more detail in the node client issue I filed. It's here: marklogic/node-client-api#64

[sammefford]

Thanks, Kim, great find. AFAICT, this isn't even mentioned in the search delta spec for ML 8. But I can confirm there is only locks-fragment-query in search.xsd, so you must be right. As I made the change I also found that properties-query has changed to properties-fragment-query. Thank goodness for StructuredQueryBuilderTest--I'm committing my changes since it passes.

[sravanr]

I am not able to pickup a test case from here, will ask Kim to verify this. I see StructuredQueryBuilderTest is not failing in regression.

[kcoleman-marklogic]

I don't know any more about creating a test case than Sravan does, but I verified it is now generating a <locks-fragment-query/> element instead of a <locks-query/> element. If that is good enough for you, Sravan, please close. If not, then you'll need to create your own test, I'm afraid.