Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Nov 30, 2022

This addresses a gap in the docs where we've never explained how to include JAXB if a user is using Java 11 or 17 and wishes to use the JAXB support in the Java Client.

Can also now build and run all the tests using Java 11 or 17 (we've only used Java 8 before). That simply required the following:

  • Don't fail the build on javadoc errors; Java 11 is much more particular about these, and we ought to do a cleanup of these errors soon, but we can ignore them for now
  • Bumped up Gradle wrapper version to the latest 7.x; to build and run on Java 17, need at least Gradle 7.3
  • Bumped up Mockito from the very, very old mockito-all dependency (last updated in 2015) to the latest ones; this fixed a simple problem with Mockito that popped up when testing with Java 11 and Java 17
  • Added a duplicatesStrategy for ml-development-tools to address an issue where the plugin properties file was getting copied over twice; this occurred as a result of upgrading from Gradle 6 to 7. There is likely a better way to handle this, but this approach (which the error message recommends using) works for now.

@rjrudin rjrudin marked this pull request as ready for review November 30, 2022 15:36
@rjrudin
Copy link
Contributor Author

rjrudin commented Nov 30, 2022

This shows an example of a test that fails on Java 11 and 17 if the old JAXB dependencies are not included, but it runs correctly with those dependencies present - marklogic/ml-javaclient-util#164

@rjrudin rjrudin mentioned this pull request Nov 30, 2022
This addresses a gap in the docs where we've never explained how to include JAXB if a user is using Java 11 or 17 and wishes to use the JAXB support in the Java Client. 

Can also now build and run all the tests using Java 11 or 17 (we've only used Java 8 before). That simply required the following:

- Don't fail the build on javadoc errors; Java 11 is much more particular about these, and we ought to do a cleanup of these errors soon, but we can ignore them for now
- Bumped up Gradle wrapper version to the latest 7.x; to build and run on Java 17, need at least Gradle 7.3
- Bumped up Mockito from the very, very old mockito-all dependency (last updated in 2015) to the latest ones; this fixed a simple problem with Mockito that popped up when testing with Java 11 and Java 17
- Added a duplicatesStrategy for ml-development-tools to address an issue where the plugin properties file was getting copied over twice; this occurred as a result of upgrading from Gradle 6 to 7. There is likely a better way to handle this, but this approach (which the error message recommends using) works for now.
@rjrudin rjrudin force-pushed the feature/java17-javax-xml branch from 3f0f002 to 57d6f9b Compare November 30, 2022 18:16
@rjrudin rjrudin merged commit 4f6ec8d into develop Dec 1, 2022
@rjrudin rjrudin deleted the feature/java17-javax-xml branch December 1, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants