DEVEXP-164: Added new factory method for DatabaseClient #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
force-pushed
the
feature/164-properties-function
branch
5 times, most recently
from
84a9add to
d4f6b4a
Compare
rjrudin
changed the title
rjrudin
requested review from
BillFarber,
anu3990,
rahulvudutala and
ryanjdew
Contributor
Author
|
@BillFarber @anu3990 Most of the changes in here are to tests, which now use the new Builder to easily customize a DatabaseClient. Only 4 app files are changed, and the changes are all additions. |
BillFarber
approved these changes
Jan 19, 2023
Contributor
BillFarber
left a comment
BillFarber
left a comment
There was a problem hiding this comment.
LGTM
These tests should be published as examples for customers (who don't want to dig through our tests for examples).
rjrudin
force-pushed
the
feature/164-properties-function
branch
from
d4f6b4a to
45808bd
Compare
Also added a `DatabaseClientBuilder`, as I found that to greatly simplify our tests that construct clients in a variety of ways. Helps shield callers from having to know all the property names as well.
rjrudin
force-pushed
the
feature/164-properties-function
branch
from
45808bd to
275d3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a
DatabaseClientBuilder, as I found that to greatly simplify our tests that construct clients in a variety of ways. Helps shield callers from having to know all the property names as well.